Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blank shank ids #17

Open
bendichter opened this issue Jan 27, 2025 · 4 comments
Open

blank shank ids #17

bendichter opened this issue Jan 27, 2025 · 4 comments

Comments

@bendichter
Copy link
Contributor

Does it make sense to have a bunch of empty fields of there are no shank IDs?
@bendichter
Copy link
Contributor Author

probeinterface_library/neuropixels/NP1010/NP1010.json

Lines 19253 to 19260 in cd8eae5

"shank_ids": [
"",
"",
"",
"",
"",
"",
"",

@alejoe91
Copy link
Member

Good point, we could only write that if shank_ids are actually defined!

@alejoe91
Copy link
Member

@samuelgarcia what do you think?

@samuelgarcia
Copy link
Member

shank_ids is not mandatory so we should shan_ids=None or not at all to have smaller files.
I thinkwe should handle this in the write function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samuelgarcia @bendichter @alejoe91