DumpSMSAPassword: collection and resolving of msds-hostserviceaccount #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or edge DumpSMSAPassword
This was referenced Dec 20, 2022
|
Hey @simondotsh it looks like one of our tests are failing with the new code. @JonasBK did an implementation of this for the v3 branch if you want to take a look at his tests and update the failing one |
|
Hi @rvazarkar, I added Jonas' unit test and null check to pass the test. Let me know if there's anything else. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of the attribute
msds-hostserviceaccounton computer objects when reading properties. It is not added to the list of properties that are shown on the UI when viewing an object since it is only collected in order to build edges. The distinguished names contained in the attribute are resolved, and only object identifiers are returned to avoid bloating with unnecessary data.For more info, see SpecterOps/BloodHound-Legacy#624.