Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No product found when using "Show all" on product list #1458

Closed
FlinthDevs opened this issue Jul 5, 2019 · 3 comments
Closed

No product found when using "Show all" on product list #1458

FlinthDevs opened this issue Jul 5, 2019 · 3 comments
Assignees
Labels

Comments

@FlinthDevs
Copy link

Using the "Show all" feature on products lists returns no result.

Preconditions

Magento Version : 2.3.1 CE
ElasticSuite Version : 2.8.0
Environment : Developper

Steps to reproduce

  1. Enable "Allow all products per page" option in admin
  2. Go on a product list page (category view or fulltext search)
  3. Select "All" in "Show X per page" select

Expected result

  1. All products are listed

Actual result

  1. No products are found and the message "We can't find products matching the selection." displayed.
@rbayet rbayet added the bug label Jul 5, 2019
@rbayet
Copy link
Collaborator

rbayet commented Jul 5, 2019

Partially fixed by #1431 (which re-introduces \Smile\ElasticsuiteCatalog\Model\ResourceModel\Product\Fulltext\Collection::loadProductCounts), but also requires to fix this in \Smile\ElasticsuiteCatalog\Model\ResourceModel\Product\Fulltext\Collection::prepareRequest ?

        // Pagination params.
        $size = $this->_pageSize ? $this->_pageSize : 0;

(It was historically

        // Pagination params.
        $size = $this->_pageSize ? $this->_pageSize : $this->getSize();
```)

@rbayet
Copy link
Collaborator

rbayet commented Jul 5, 2019

See also #1428

@romainruaud
Copy link
Collaborator

Fixed by associated PR #1460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants