[profdata] update spec usage to expect instead of should

Author: Matt Delves

spec/slather/coverage_service/cobertura_xml_spec.rb

@@ -33,7 +33,7 @@
         source_node.content = ''
       end
 
-      EquivalentXml.equivalent?(current_xml_doc, fixture_xml_doc).should be_truthy
+      expect(EquivalentXml.equivalent?(current_xml_doc, fixture_xml_doc)).to be_truthy
     end
 
     it "should create an XML report in the given output directory" do

spec/slather/coverage_service/coveralls_spec.rb

@@ -122,7 +122,7 @@
       fixtures_project.post
       expect(File.exist?("coveralls_json_file")).to be_falsy
       fixtures_project.stub(:travis_job_id).and_return(nil)
-      expect { fixtures_project.post }.to raise_error
+      expect { fixtures_project.post }.to raise_error(StandardError)
       expect(File.exist?("coveralls_json_file")).to be_falsy
     end
   end

spec/slather/coverage_service/hardcover_spec.rb

@@ -80,7 +80,7 @@
       fixtures_project.post
       expect(File.exist?("hardcover_json_file")).to be_falsy
       fixtures_project.stub(:jenkins_job_id).and_return(nil)
-      expect { fixtures_project.post }.to raise_error
+      expect { fixtures_project.post }.to raise_error(StandardError)
       expect(File.exist?("hardcover_json_file")).to be_falsy
     end
   end