Skip to content

Commit 1eed191

Browse files
committed
fix doc for trace_exporter config
1 parent f128492 commit 1eed191

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

docs/references/configs/page.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ This document lists all the configuration options supported by the GoFr framewor
6565
---
6666

6767
- TRACE_EXPORTER
68-
- Tracing exporter to use. Supported values: gofr, zipkin, jaeger.
69-
- gofr
68+
- Tracing exporter to use. Supported values: gofr, zipkin, jaeger, otlp.
7069

7170
---
7271

pkg/gofr/gofr.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,6 @@ func (a *App) initTracer() {
319319

320320
if traceExporter == "" {
321321
a.Logger().Errorf("missing TRACE_EXPORTER config, should be provided with TRACER_URL to enable tracing")
322-
323322
return
324323
}
325324

@@ -355,7 +354,7 @@ func (a *App) getExporter(ctx context.Context, name, url, authHeader string) (sd
355354
case traceExporterOTLP:
356355
return a.buildOpenTelemetryProtocol(ctx, url, strings.ToLower(name), authHeader)
357356
case traceExporterJaeger:
358-
// jaeger accept OpenTelemetry Protocol (OTLP) .
357+
// jaeger accept OpenTelemetry Protocol (OTLP)
359358
return a.buildOpenTelemetryProtocol(ctx, url, strings.ToLower(name), authHeader)
360359
case traceExporterZipkin:
361360
return a.buildZipkin(url, authHeader)
@@ -368,7 +367,7 @@ func (a *App) getExporter(ctx context.Context, name, url, authHeader string) (sd
368367
}
369368

370369
// buildOpenTelemetryProtocol using OpenTelemetryProtocol as the trace exporter
371-
// jaeger accept OpenTelemetry Protocol (OTLP) over gRPC to upload trace data .
370+
// jaeger accept OpenTelemetry Protocol (OTLP) over gRPC to upload trace data
372371
func (a *App) buildOpenTelemetryProtocol(ctx context.Context, url, exporter, authHeader string) (sdktrace.SpanExporter, error) {
373372
a.container.Logf("Exporting traces to %s at %s", exporter, url)
374373

0 commit comments

Comments
 (0)