Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme download should store checksums of each individually downloaded file for faster comparisson #835

Closed
vfonic opened this issue Nov 4, 2020 · 5 comments

Comments

@vfonic
Copy link

vfonic commented Nov 4, 2020

Is your feature request related to a problem? Please describe.

This is related to #801 (theme download gets stuck at 97%).
The issue is that theme download never reaches 100%.

Describe the solution you'd like

I noticed that in the newer versions of themekit, themekit smartly compares local and remote files,
making it much faster on subsequent runs.
I'd love to be able to use this feature.

Describe alternatives you've considered

I've considered using v1.0.2, but v1.0.2 downloads all files every time I run theme download.

@tanema
Copy link
Contributor

tanema commented Nov 4, 2020

I am sorry, is this an issue or is this just you trying to add to an already existing issue?

@tanema tanema closed this as completed Nov 4, 2020
@vfonic
Copy link
Author

vfonic commented Nov 4, 2020

To me this seemed like a separate issue.

I don't know the internals of themekit, but what I noticed recently is that newer versions of themekit somehow magically remember which files are the same and don't need to be downloaded again.

Running theme download twice on v1.0.2 will run the full theme download twice.
Running theme download twice on v1.1.2 will run the full theme download once and will just download couple of files the second time.

Is this related to theme download stalls at 96%? I don't think so.

Please also notice that this is a feature request and not a bug report.

@tanema
Copy link
Contributor

tanema commented Nov 4, 2020

This is directly related to that functionality, and the functionality already exists and is implemented.

@vfonic
Copy link
Author

vfonic commented Nov 4, 2020

@tanema from my experience using themekit, this is what seems to happen after you run theme download:

  1. The files are downloaded in parallel
  2. Once all of the files are downloaded, the checksums are stored

The workflow I'm suggesting is:

  1. The files are downloaded in parallel
  2. As each file is downloaded, its checksum is stored immediately.

Perhaps I don't fully understand how this works, especially since I don't see any local changes if theme download successfully finishes (I have no clue where/how the checksums are stored). This would partially fix the other issue, as subsequent theme downloads might actually pass as they will download less files. The main issue of #801 will still not be addressed (initial download).

@tanema
Copy link
Contributor

tanema commented Nov 5, 2020

Themekit does not store anything other than files. Themekit needs a file on the filesystem to check the content of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants