-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme download
should store checksums of each individually downloaded file for faster comparisson
#835
Comments
I am sorry, is this an issue or is this just you trying to add to an already existing issue? |
To me this seemed like a separate issue. I don't know the internals of themekit, but what I noticed recently is that newer versions of themekit somehow magically remember which files are the same and don't need to be downloaded again. Running Is this related to Please also notice that this is a feature request and not a bug report. |
This is directly related to that functionality, and the functionality already exists and is implemented. |
@tanema from my experience using themekit, this is what seems to happen after you run
The workflow I'm suggesting is:
Perhaps I don't fully understand how this works, especially since I don't see any local changes if |
Themekit does not store anything other than files. Themekit needs a file on the filesystem to check the content of. |
Is your feature request related to a problem? Please describe.
This is related to #801 (theme download gets stuck at 97%).
The issue is that
theme download
never reaches 100%.Describe the solution you'd like
I noticed that in the newer versions of themekit, themekit smartly compares local and remote files,
making it much faster on subsequent runs.
I'd love to be able to use this feature.
Describe alternatives you've considered
I've considered using v1.0.2, but v1.0.2 downloads all files every time I run
theme download
.The text was updated successfully, but these errors were encountered: