Fix fetch_annotation signature
#2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Feb 20, 2025
KaanOzkan
approved these changes
Feb 20, 2025
|
CI issue is known #2212. Tried a quick filtering fix but the assertion requires a Spoom::ExecResult and not a String |
paracycle
approved these changes
Feb 21, 2025
This code works by miracle. We call `fetch_annotation` within a `select` but the method return `void`. It only works because the `T::Private::Types::Void::VOID` used by `sorbet-runtime` to replace the actual value is truthy. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-fix-annotations
branch
from
3ecd697 to
23fa10b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code works by miracle.
We call
fetch_annotationwithin aselectbut the method returnvoid. It only works because theT::Private::Types::Void::VOIDused bysorbet-runtimeto replace the actual value is truthy.