Fix duplicate LSP features appearing in multiroot workspaces #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
andyw8
added
bugfix
andyw8
changed the title
vinistock
approved these changes
May 29, 2024
|
I can't quite connect the code change with the problem it solves. Mind adding a bit of explanation on how it works 🤔 |
|
For each app in the multiroot workspace there is a seperate LSP instance. If we have only |
|
Ah that makes sense. Thx 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2052
Co-authored with @vinistock
(
TODO: Log an issue for vscode-languageserver-node about seeing unexpected requests for semanticToken for a workspace that isn't even open) microsoft/vscode-languageserver-node#1487