From 45eb589f262c88fbc2e91a4f9555932f118d7542 Mon Sep 17 00:00:00 2001 From: Kaelig Deloumeau-Prigent Date: Wed, 20 Nov 2019 23:30:25 -0800 Subject: [PATCH 1/2] [Icon] Point to the public documentation The Shopify/polaris-icons repository is now private, meaning non-Shopify employees would get a 404 by clicking on the link pointing to https://github.com/Shopify/polaris-icons/tree/master/packages/polaris-icons. --- src/components/Icon/README.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/Icon/README.md b/src/components/Icon/README.md index be26e8e3f06..f633e7a0527 100644 --- a/src/components/Icon/README.md +++ b/src/components/Icon/README.md @@ -103,8 +103,6 @@ If the icon appears without text, then use the `accessibilityLabel` prop to give ## Related guidelines -- To learn about implementing Polaris icons with [Polaris React](https://github.com/Shopify/polaris-react) in your projects, see the [`@shopify/polaris-icons` documentation](https://github.com/Shopify/polaris-icons/tree/master/packages/polaris-icons) - +- To learn about implementing Polaris icons with [Polaris React](https://github.com/Shopify/polaris-react) in your projects, see the [`@shopify/polaris-icons` documentation](https://www.npmjs.com/package/@shopify/polaris-icons) - To learn about the best practices for designing and using icons in your projects, see the [icon design guidelines](https://polaris.shopify.com/design/icons) - - To learn how to name icons, see the [icon naming guidelines](https://polaris.shopify.com/content/naming#section-icons) From 955c9dddae2f6b3a2fbf800845595ba668525a0a Mon Sep 17 00:00:00 2001 From: Kaelig Deloumeau-Prigent Date: Wed, 20 Nov 2019 23:34:45 -0800 Subject: [PATCH 2/2] Update UNRELEASED.md --- UNRELEASED.md | 1 + 1 file changed, 1 insertion(+) diff --git a/UNRELEASED.md b/UNRELEASED.md index 017db5e272f..5dab152652d 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -22,6 +22,7 @@ - Added a details page and kitchen sink example to Storybook ([#2402](https://github.com/Shopify/polaris-react/pull/2402)) - Combined the interface used by `Page` so the types can be parsed ([#2358](https://github.com/Shopify/polaris-react/pull/2358)) +- Changed a link to the Polaris icons documentation so it would point to npm (a public resource) rather than the `Shopify/polaris-icons` repository (which is now private) ([#2452](https://github.com/Shopify/polaris-react/pull/2452)) ### Development workflow