-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filters] Button width changes when popover is active #1853
Comments
Hey @tmlayton I'm up for fixing this. Is there a reproducible example? I can't seem to reproduce when it's just a standalone button with a popover. |
👋 Hey @alexieyizhe! That would be awesome, and sorry I quickly opened the issue so there is no information. The issue is with the new |
Sweet, apologies for late reply but I'll have a look later today! |
Hey @tmlayton, bit late but I put in a PR^^ to fix this issue. The check that's failing is a Percy snapshot comparison, but I can't seem to approve the change. Check it out when you have the time! |
@tmlayton is on holiday for the next week or two. @chloerice, if you've got a spare moment would you be able to take a look at Alex's PR at some point? |
The new
Filters
component has a concept for "shortcut" filters which adds a button/popover in the filter bar to quickly access the filter. The last (right-most) shortcut filter has a visual bug in the button when activating the popover:Reduced test case
https://codesandbox.io/s/epic-cookies-333ch
The text was updated successfully, but these errors were encountered: