Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filters] Button width changes when popover is active #1853

Closed
tmlayton opened this issue Jul 16, 2019 · 5 comments · Fixed by #2003
Closed

[Filters] Button width changes when popover is active #1853

tmlayton opened this issue Jul 16, 2019 · 5 comments · Fixed by #2003
Labels
Bug Something is broken and not working as intended in the system.

Comments

@tmlayton
Copy link
Contributor

tmlayton commented Jul 16, 2019

The new Filters component has a concept for "shortcut" filters which adds a button/popover in the filter bar to quickly access the filter. The last (right-most) shortcut filter has a visual bug in the button when activating the popover:

filters bug

Reduced test case

https://codesandbox.io/s/epic-cookies-333ch

@tmlayton tmlayton self-assigned this Jul 16, 2019
@tmlayton tmlayton added ⚗️ Development Bug Something is broken and not working as intended in the system. labels Jul 16, 2019
@tmlayton tmlayton removed their assignment Jul 16, 2019
@alexieyizhe
Copy link
Contributor

Hey @tmlayton I'm up for fixing this. Is there a reproducible example? I can't seem to reproduce when it's just a standalone button with a popover.

@tmlayton
Copy link
Contributor Author

tmlayton commented Aug 5, 2019

👋 Hey @alexieyizhe! That would be awesome, and sorry I quickly opened the issue so there is no information. The issue is with the new Filters component: https://polaris.shopify.com/components/lists-and-tables/filters and is reproducible in the latest Chrome, Firefox, and Safari as far as I tested. Will update the description.

@alexieyizhe
Copy link
Contributor

alexieyizhe commented Aug 20, 2019

Sweet, apologies for late reply but I'll have a look later today!

@alexieyizhe
Copy link
Contributor

Hey @tmlayton, bit late but I put in a PR^^ to fix this issue. The check that's failing is a Percy snapshot comparison, but I can't seem to approve the change. Check it out when you have the time!

@BPScott
Copy link
Member

BPScott commented Aug 26, 2019

@tmlayton is on holiday for the next week or two. @chloerice, if you've got a spare moment would you be able to take a look at Alex's PR at some point?

@mitchmaps mitchmaps removed their assignment Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants