Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Expose onScrolledToBottom on Modal from it's Scrollable implementation #1116

Closed
posth opened this issue Mar 1, 2019 · 3 comments
Closed
Assignees

Comments

@posth
Copy link
Contributor

posth commented Mar 1, 2019

Modal

If using Scrollable as the Modal's content, it's onScrolledToBottom handler won't get triggered.

The Modal component implements it's own Scrollable here

Maybe exposing that implementation's handler as a new prop on Modal may enable consumers of Modal to play around with infinite scrolling, for example.

Examples

Here is an example that uses Scrollable with a handler wrapped within the Modal. The Scrollable handler does not get called when reaching the bottom.

The issue seems to be related to the content within Scrollable being dynamically generated, because here is an example that has fixed content where the behavior is as expected.

Here is an example of Scrollable on its own triggering the handler.

@AndrewMusgrave
Copy link
Member

This makes sense to me. It'll prevent nesting Scrollable which may be weird UI issues. I think it'll be a great addition 😄

@AndrewMusgrave
Copy link
Member

Looks like you'r already started a WIP pr so i'll assign this issue to you @posth

@posth
Copy link
Contributor Author

posth commented Mar 1, 2019

Hey @AndrewMusgrave thanks for the quick feedback!

Yes I went ahead and created a quick PR #1117 for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants