[FormLayout] min-width added to Item only when in Group.

[dleroux]

WHY are these changes introduced?

Resolves https://github.com/Shopify/web/issues/4902

There's a min-width set on FormLayout Items t

hat is used for wrapping of items when inside a group. In the side column however that min-width is too wide.

WHAT is this pull request doing?

Adding the min-width to items when in groups only.

Before	After
Content from cell 1	Content from cell 2

How to 🎩

1. Below is the Polaris-React Playground
2. yarn build-consumer web to 🎩 in web

Copy-paste this code in playground/Playground.tsx:

import * as React from 'react';
import {Page, FormLayout, TextField} from '@shopify/polaris';

interface State {}

export default class Playground extends React.Component<never, State> {
  render() {
    return (
      <Page title="Playground">
        <FormLayout>
          <FormLayout.Group>
            <TextField label="Length" onChange={() => {}} />
            <TextField label="Width" onChange={() => {}} />
            <TextField label="Height" onChange={() => {}} />
            <TextField label="Unit" onChange={() => {}} />
          </FormLayout.Group>
          <FormLayout.Group condensed>
            <TextField label="Length" onChange={() => {}} />
            <TextField label="Width" onChange={() => {}} />
            <TextField label="Height" onChange={() => {}} />
            <TextField label="Unit" onChange={() => {}} />
          </FormLayout.Group>
        </FormLayout>
      </Page>
    );
  }
}

🎩 checklist

• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated UNRELEASED.md

[dleroux]

Opted to keep the flex-basis as part of the Item to minimize the change.

[AndrewMusgrave]

🎩

[AndrewMusgrave]

Why .5? Should we save this to a variable?

[dleroux]

This was like this so I opted not to touch it. It's only used once so I don't see an issue with it. Do you?

[danrosenthal]

I think this is fine as is. I think this pretty clearly communicates that it is half the item min size.

[danrosenthal]

We do the same thing with * -1 to make a number negative. We don't add variables for that