Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Fix container's width #2692

Merged
merged 2 commits into from
Feb 6, 2020
Merged

[Modal] Fix container's width #2692

merged 2 commits into from
Feb 6, 2020

Conversation

mickaelzhang
Copy link
Contributor

WHY are these changes introduced?

There is currently an issue with the Modal's width as it doesn't take into account the scroll bar when visible.

Capture d’écran 2020-01-31 à 15 10 25

WHAT is this pull request doing?

I've changed the value from vw to % as this one take the scroll bar into account

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@ghost
Copy link

ghost commented Jan 31, 2020

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@ghost ghost added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Jan 31, 2020
@dpersing
Copy link
Contributor

dpersing commented Feb 3, 2020

Hi @mickaelzhang! Thanks so much for contributing. While we take a look at your PR, could you review and sign our Contributor License Agreement (CLA)? That will need to be complete before we can merge any PRs. Thanks!

@mickaelzhang
Copy link
Contributor Author

Hi @dpersing! Yes sorry, I just saw that I needed to sign the CLA. It should be done now 👍

@dleroux
Copy link
Contributor

dleroux commented Feb 6, 2020

Hi @mickaelzhang,

Just tested and it works great. I would love to approve but it doesn't show that the CLA has been signed. Can you double-check? We'll also need a UNRELEASED.md entry before we can ship as well.

@mickaelzhang
Copy link
Contributor Author

mickaelzhang commented Feb 6, 2020

@dleroux Weird 🤔 It says that I already signed it

Capture d’écran 2020-02-06 à 15 36 13

I'll add the entry in UNRELEASED.md when I have a bit of time :)

@dleroux
Copy link
Contributor

dleroux commented Feb 6, 2020

That is strange. I'll investigate and get back to you. Thanks!

@ghost ghost removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Feb 6, 2020
@mickaelzhang
Copy link
Contributor Author

@dleroux I made the update on the UNRELEASED.md! I think I just needed to push something, seems fine now for the CLA :)

@dleroux dleroux merged commit 225f2ae into Shopify:master Feb 6, 2020
@ghost
Copy link

ghost commented Feb 6, 2020

🎉 Thanks for your contribution to Polaris React!

@mickaelzhang mickaelzhang deleted the patch-1 branch February 7, 2020 09:19
@tmlayton tmlayton temporarily deployed to production March 7, 2020 05:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants