-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal] Fix container's width #2692
Conversation
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
Hi @mickaelzhang! Thanks so much for contributing. While we take a look at your PR, could you review and sign our Contributor License Agreement (CLA)? That will need to be complete before we can merge any PRs. Thanks! |
Hi @dpersing! Yes sorry, I just saw that I needed to sign the CLA. It should be done now 👍 |
Hi @mickaelzhang, Just tested and it works great. I would love to approve but it doesn't show that the CLA has been signed. Can you double-check? We'll also need a UNRELEASED.md entry before we can ship as well. |
@dleroux Weird 🤔 It says that I already signed it I'll add the entry in UNRELEASED.md when I have a bit of time :) |
That is strange. I'll investigate and get back to you. Thanks! |
@dleroux I made the update on the UNRELEASED.md! I think I just needed to push something, seems fine now for the CLA :) |
🎉 Thanks for your contribution to Polaris React! |
WHY are these changes introduced?
There is currently an issue with the Modal's width as it doesn't take into account the scroll bar when visible.
WHAT is this pull request doing?
I've changed the value from
vw
to%
as this one take the scroll bar into account🎩 checklist
README.md
with documentation changes