[ChoiceList] Add JSX support to the title prop

[jtrollia]

WHY are these changes introduced?

There are cases where a ChoiceList requires nested translations/HTML tags in its title.

WHAT is this pull request doing?

Switching title's prop type from string to a more permissive ReactNode.

How to 🎩

yarn dev / playground

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:

import React from 'react';
import {Page, ChoiceList} from '../src';

const choices = [
  {label: 'One', value: 'one'},
  {label: 'Two', value: 'two'},
  {label: 'Three', value: 'three'},
];

const JsxTitle = () => (
  <React.Fragment>
    JSX <b>title</b>
  </React.Fragment>
);

export function Playground() {
  return (
    <Page title="Playground">
      <ChoiceList title={<JsxTitle />} selected={[]} choices={choices} />,
    </Page>
  );
}

🎩 checklist

• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated the component's README.md with documentation changes
• Tophatted documentation changes in the style guide
• For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

[github-actions]

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.

---

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

[LauraAubin]

LGTM! 🎉

[BPScott]

Thanks @jtrollia! merge at your leisure

[jtrollia]

@BPScott @LauraAubin I assume these have been re-introduced by the latest revert - should I removed them in this PR?

[BPScott]

Unsure of the top of my head - rebase atop latest master and see what ends up being in this file

[jtrollia]

That's what I did :o

As you can see the latest version of the file, there are references to stuff that have been merged and shipped already - hence my confusion

From what I understand from the guidelines

The changelog is prepared manually immediately before a release, by moving changelog entries from UNRELEASED.md to CHANGELOG.md, under a new heading for the version number.

We have to clear the file manually?

[LauraAubin]

Those entries must have not been cleared from the unreleased file with the latest release. Since they are referenced in the changelog, and I don't see a revert, I think it's fine to remove those entries from the unreleased doc.

[jtrollia]

I was referring to #2377, anyways I can clear the doc 👍