Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spinner] Improved accessibility docs #2258

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

Fixes #2236

@AndrewMusgrave AndrewMusgrave force-pushed the spinner-accessibility-docs branch from fff0dca to d7e3b92 Compare October 7, 2019 22:29
@AndrewMusgrave AndrewMusgrave changed the title 📝 Improved accessibility docs Improved accessibility docs Oct 7, 2019
@AndrewMusgrave AndrewMusgrave changed the title Improved accessibility docs [Spinner] Improved accessibility docs Oct 7, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2019

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@AndrewMusgrave AndrewMusgrave force-pushed the spinner-accessibility-docs branch from 5d1e203 to ad2915e Compare October 8, 2019 16:00
@AndrewMusgrave AndrewMusgrave force-pushed the spinner-accessibility-docs branch from ad2915e to 67fcc8c Compare October 9, 2019 19:20
Copy link
Contributor

@dpersing dpersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Awesome! Thank you, @AndrewMusgrave!

@AndrewMusgrave AndrewMusgrave merged commit 5429427 into master Oct 10, 2019
@AndrewMusgrave AndrewMusgrave deleted the spinner-accessibility-docs branch October 10, 2019 18:36
@tmlayton tmlayton temporarily deployed to production October 16, 2019 00:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spinner] Improve accessibility docs
4 participants