[MediaQueryProvider] Add media query provider #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
force-pushed
the
add-media-query-provider
branch
2 times, most recently
from
9ad816a to
821f784
Compare
AndrewMusgrave
changed the title
AndrewMusgrave
commented
Sep 11, 2019
| import {LinkContext} from '../../../utilities/link'; | ||
| import {AppProvider} from '../AppProvider'; | ||
|
|
||
| describe('<AppProvider />', () => { | ||
| beforeEach(() => { |
There was a problem hiding this comment.
AppProvider renders MediaQueryProvider now which uses matchMedia and since jsdom doesn't provide it, we'll need it mock it.
AndrewMusgrave
commented
Sep 11, 2019
| const navigation = <div />; | ||
| const frame = mountWithAppProvider( | ||
| <Frame showMobileNavigation navigation={navigation} />, | ||
| {mediaQuery: {isNavigationCollapsed: true}}, |
There was a problem hiding this comment.
This passes the value to PolarisTestProvider which passes it to MediaQueryContext.Provider to mock isNavigationCollapsed
AndrewMusgrave
commented
Sep 11, 2019
| children?: React.ReactNode; | ||
| } | ||
|
|
||
| export const MediaQueryProvider = function MediaQueryProvider({ |
There was a problem hiding this comment.
We check the breakpoint, when the state is initialized, after the first render and during resize.
AndrewMusgrave
commented
Sep 11, 2019
| interface State { | ||
| mobileView?: boolean; | ||
| } | ||
| export function Header({ |
There was a problem hiding this comment.
After removing the breakpoint logic I was able to convert Header into a functional component 😄
AndrewMusgrave
force-pushed
the
add-media-query-provider
branch
from
a1cc5e7 to
a5807d2
Compare
AndrewMusgrave
requested review from
dleroux,
LauraAubin and
alex-page
and removed request for
LauraAubin
6 tasks
AndrewMusgrave
force-pushed
the
add-media-query-provider
branch
from
a5807d2 to
d8c0d1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Reduce duplicated logic and add a location where we can easily add to it
WHAT is this pull request doing?
How to 🎩
You'll want to check Filters, Frame, Navigation, Page and Sheet in the deployment across screen sizes to ensure navigation collapsed is still working correctly.
🎩 checklist
README.mdwith documentation changes