Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for Single ChoiceList error state #2007

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

see-mack
Copy link
Contributor

WHY are these changes introduced?

Fixes #1943

WHAT is this pull request doing?

Adds references to single choice list error state images (added in https://github.com/Shopify/polaris-styleguide/pull/2928)

@ghost
Copy link

ghost commented Aug 26, 2019

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@see-mack see-mack force-pushed the mobile-single-choice-error branch from 9886a25 to f36d317 Compare August 27, 2019 19:54
@see-mack see-mack force-pushed the mobile-single-choice-error branch from f36d317 to dbcc1ec Compare September 5, 2019 20:27
Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@see-mack see-mack merged commit 183b103 into master Sep 6, 2019
@see-mack see-mack deleted the mobile-single-choice-error branch September 6, 2019 18:30
@ghost
Copy link

ghost commented Sep 6, 2019

🎉 Thanks for your contribution to Polaris React!

@chloerice chloerice temporarily deployed to production September 9, 2019 21:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Choice list] "Single choice list with error" should have iOS/Android screenshots
3 participants