Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ActionList] Fix color of icon in destructive ActionList item #1836

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

Tetsuro
Copy link

@Tetsuro Tetsuro commented Jul 15, 2019

WHY are these changes introduced?

Fixes #1835

Before After
image image

WHAT is this pull request doing?

Uses the recolor-icon() mixin to recolor the icon for destructive ActionList items.

How to 🎩

Please see the Action list with destructive item example in Storybook.

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

@ghost
Copy link

ghost commented Jul 15, 2019

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

@Tetsuro Tetsuro self-assigned this Jul 15, 2019
@BPScott BPScott requested a deployment to polaris-react-pr-1836 July 15, 2019 20:18 Abandoned
@Tetsuro Tetsuro requested a review from beefchimi July 15, 2019 20:18
@BPScott BPScott requested a deployment to polaris-react-pr-1836 July 15, 2019 20:21 Abandoned
Copy link
Contributor

@danrosenthal danrosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@markiiikram markiiikram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Tetsuro Tetsuro merged commit b6723b2 into master Jul 15, 2019
@ghost
Copy link

ghost commented Jul 15, 2019

🎉 Thanks for your contribution to Polaris React!

@Tetsuro Tetsuro deleted the action-list/fix-destructive-icon-color branch July 15, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ActionList] Destructive items do not set icon color to red
4 participants