[Card] Add example for card with footer action + plain button #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack. |
ghost
added
the
cla-needed
|
Signed CLA |
ghost
removed
the
cla-needed
chloerice
requested changes
Jun 20, 2019
There was a problem hiding this comment.
Thanks for your contribution @sharoonthomas! I've suggested a couple of changes to the content to make the "why" of the example clear. Otherwise, the code for the example is spot on and looks as expected!
|
Thanks for the feedback @chloerice. Updated the PR with the changes you suggested. |
chloerice
approved these changes
Jun 21, 2019
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #562
WHAT is this pull request doing?
Adds an example of the card where custom buttons are added, similar to how they are used in some parts of Shopify. The example adds a secondary button and a plain button to the footer of the card.