Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Constrain drop zone height based on inherited wrapper height" #1129

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented Mar 6, 2019

This reverts commit c4a52d4.

Reason for the revert: #1127

@BPScott BPScott temporarily deployed to polaris-react-pr-1129 March 6, 2019 16:41 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1129 March 6, 2019 16:58 Inactive
@AndrewMusgrave AndrewMusgrave force-pushed the revert-dz-height-change branch from 6ebc94c to 84073b5 Compare March 6, 2019 17:03
@BPScott BPScott temporarily deployed to polaris-react-pr-1129 March 6, 2019 17:03 Inactive
@AndrewMusgrave AndrewMusgrave force-pushed the revert-dz-height-change branch from 84073b5 to 8ceecd7 Compare March 6, 2019 17:11
@BPScott BPScott temporarily deployed to polaris-react-pr-1129 March 6, 2019 17:11 Inactive
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might want to add a description as to why the revert.

@AndrewMusgrave
Copy link
Member Author

I'll link this with the other PR @dleroux

@AndrewMusgrave
Copy link
Member Author

Something seems wrong with codecov, it's been running for about 40 minutes now. Going to send up a empty commit to rerun checks and 🤞

@BPScott BPScott temporarily deployed to polaris-react-pr-1129 March 6, 2019 17:49 Inactive
@AndrewMusgrave AndrewMusgrave force-pushed the revert-dz-height-change branch from ae5a726 to 8ceecd7 Compare March 6, 2019 17:55
@AndrewMusgrave AndrewMusgrave merged commit 9b39994 into master Mar 6, 2019
@AndrewMusgrave AndrewMusgrave deleted the revert-dz-height-change branch March 6, 2019 18:13
@amrocha amrocha temporarily deployed to production March 7, 2019 22:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants