[Autocomplete] Fix incorrect selected state in examples #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack. |
jim-chou-shopify
force-pushed
the
fix-autocomplete-examples
branch
from
38b4a2d to
b7e5555
Compare
jim-chou-shopify
force-pushed
the
fix-autocomplete-examples
branch
from
b7e5555 to
9147892
Compare
jim-chou-shopify
force-pushed
the
fix-autocomplete-examples
branch
from
9147892 to
89b9770
Compare
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Few README examples in autocomplete component use label of selected options as selected state in
onSelectcallbacks.This causes selected options not to be highlighted and developers wondering what
selectedprop does in Autocomplete component.WHAT is this pull request doing?
Update
selectedstate with selected props received fromonSelectcallback so selected options are highlighted.