Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Layout bug with number fields and suffix #96

Closed
asacarter opened this issue Jun 16, 2017 · 6 comments
Closed

CSS Layout bug with number fields and suffix #96

asacarter opened this issue Jun 16, 2017 · 6 comments

Comments

@asacarter
Copy link

Issue summary

In Firefox, if a number text field also contains a suffix and the width of the text field is 240px or smaller, the increment and decrement buttons appear to be outside of the text box.

The issue does not seem to occur in Chrome.

Expected behavior

Layout should display as it does in Chrome.

Actual behavior

Layout is broken in Firefox.

screen shot 2017-06-16 at 00 55 02

Layout is fine in Chrome

screen shot 2017-06-16 at 01 00 32

Steps to Reproduce the Problem

  1. Create a text area of type number.
  2. Add a suffix such as 'weeks'.
  3. Make the container 240px.
  4. View the result in Firefox and compare with Chrome.

Specifications

  • Polaris version: 1.0.3
  • React version: n/a
  • Browser: Firefox 53.0.3
  • Device: PC
  • Operating System: Windows 10
@lemonmade
Copy link
Member

Thanks for the issue, @asacarter. I was able to recreate locally. I've added a note to our internal issue tracker and we should get this fixed soon.

@lemonmade
Copy link
Member

Should be fixed by v1.1.0

@asacarter
Copy link
Author

Still not resolved in v1.1.1 using the same HTML structure. Or has that changed?

Hopefully this can be looked at again as it is breaking layouts when used in a sidebar or on mobile.

@lemonmade
Copy link
Member

Shoot, you are right. We didn't get this fix into the 1.1.0 release. We will get a release out this week that includes it.

@lemonmade lemonmade reopened this Jul 4, 2017
@dfmcphee
Copy link
Contributor

This should be resolved now.

@asacarter
Copy link
Author

It seems to be resolved in our app now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants