[ResourceList] Fix for the plural resource name when totalItemsCount is greater than 1 #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleroux
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Awesome! Thank you for doing this @mbaumbach.
There's a conflict with the changelog but after that, it's good to go.
mbaumbach
requested review from
BPScott,
danrosenthal and
tmlayton
as code owners
|
Are the changes to eslintignore and all the components other than ResourceList desired? They all look unrelated? |
|
@BPScott Nope, not desired. I think that may have been due to a merge with master. I thought I rebased those when trying to resolve the conflicts with I can always create a new branch with just these changes if that's preferred. |
|
Rebasing this atop latest master is fine, no need for new branches and new PRs :) |
|
Apologies about that auto-close of the PR. Should be all set now, I think. |
|
Will squash and merge once the checks pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #2299
When the
ResourceListhas only item showing, but atotalItemsCountgreater than 1, it was using the singular form of the resource name when it should use the plural.WHAT is this pull request doing?
Whenever there's a
totalItemsCountand it's not equal to 1, it will use the plural form of the resource name.🎩 checklist
README.mdwith documentation changes