Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceList.Item doesn't change page on click with URL #14

Closed
sdn90 opened this issue Apr 23, 2017 · 2 comments
Closed

ResourceList.Item doesn't change page on click with URL #14

sdn90 opened this issue Apr 23, 2017 · 2 comments

Comments

@sdn90
Copy link

sdn90 commented Apr 23, 2017

Issue summary

Clicking on ResourceList.Item doesn't change the URL.

Expected behavior

Clicking on ResourceList.Item should go to the url prop

Actual behavior

Nothing

Specifications

  • Polaris version: 1.0.1
  • React version: 15.4.2

This is where it is in the code:
https://github.com/Shopify/polaris/blob/master/src/components/ResourceList/Item.tsx#L188-L193

Looks like containerMarkup needs to be added as a child of UnstyledLink

@sdn90
Copy link
Author

sdn90 commented Apr 23, 2017

Actually just realized you guys are having the <a> positioned absolute.

Problem is that the class .Link doesn't define a width.
https://github.com/Shopify/polaris/blob/master/src/components/ResourceList/ResourceList.scss#L274-L281

@ry5n
Copy link
Contributor

ry5n commented Apr 24, 2017

Thanks @sdn90 for catching this. Currently our setup is a bit unusual—active development is happening on an internal repo in the short term. I’ve verified this and created an issue on that repo. You should see a fix land in the next release. Until then I’ll keep you posted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants