Remove wrong cache control headers #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo store is setting
cache-controlheader when it is not suppose to. The demo store server renders cart information. Cart information is consider personalized content and should never be cached in any way.Route
($locale).api.countries.tsxcan have cache control header because it is an API endpoint that doesn't render the cart.WHY are these changes introduced?
Fixes https://github.com/Shopify/hydrogen-internal/issues/61
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist