Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a /admin route that redirects to the online store admin page #989

Merged
merged 2 commits into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/spicy-mayflies-own.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
'@shopify/hydrogen': patch
---

Add a `/admin` route that redirects to the Shopify admin. This redirect can be disabled by passing `noAdminRedirect: true` to `storefrontRedirect`:

```ts
storefrontRedirect({
redirect,
response,
storefront,
noAdminRedirect: true,
});
```
1 change: 1 addition & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 13 additions & 5 deletions packages/hydrogen/docs/generated/generated_docs_data.json
Original file line number Diff line number Diff line change
Expand Up @@ -1381,35 +1381,43 @@
"name": "Promise<Response>",
"value": "Promise<Response>"
},
"value": "export async function storefrontRedirect(\n options: StorefrontRedirect,\n): Promise<Response> {\n const {\n storefront,\n request,\n response = new Response('Not Found', {status: 404}),\n } = options;\n\n const {pathname, search} = new URL(request.url);\n const redirectFrom = pathname + search;\n\n try {\n const {urlRedirects} = await storefront.query<{\n urlRedirects: UrlRedirectConnection;\n }>(REDIRECT_QUERY, {\n variables: {query: 'path:' + redirectFrom},\n });\n\n const location = urlRedirects?.edges?.[0]?.node?.target;\n\n if (location) {\n return new Response(null, {status: 301, headers: {location}});\n }\n\n const searchParams = new URLSearchParams(search);\n const redirectTo =\n searchParams.get('return_to') || searchParams.get('redirect');\n\n if (redirectTo) {\n if (isLocalPath(redirectTo)) {\n return redirect(redirectTo);\n } else {\n console.warn(\n `Cross-domain redirects are not supported. Tried to redirect from ${redirectFrom} to ${redirectTo}`,\n );\n }\n }\n } catch (error) {\n console.error(\n `Failed to fetch redirects from Storefront API for route ${redirectFrom}`,\n error,\n );\n }\n\n return response;\n}"
"value": "export async function storefrontRedirect(\n options: StorefrontRedirect,\n): Promise<Response> {\n const {\n storefront,\n request,\n noAdminRedirect,\n response = new Response('Not Found', {status: 404}),\n } = options;\n\n const {pathname, search} = new URL(request.url);\n const redirectFrom = pathname + search;\n\n if (pathname === '/admin' && !noAdminRedirect) {\n const match = /https:\\/\\/([^.]+)\\.myshopify\\.com/g.exec(\n storefront.getShopifyDomain(),\n );\n return redirect(\n match && match[1]\n ? `https://admin.shopify.com/store/${match[1]}`\n : `${storefront.getShopifyDomain()}/admin`,\n );\n }\n\n try {\n const {urlRedirects} = await storefront.query<{\n urlRedirects: UrlRedirectConnection;\n }>(REDIRECT_QUERY, {\n variables: {query: 'path:' + redirectFrom},\n });\n\n const location = urlRedirects?.edges?.[0]?.node?.target;\n\n if (location) {\n return new Response(null, {status: 301, headers: {location}});\n }\n\n const searchParams = new URLSearchParams(search);\n const redirectTo =\n searchParams.get('return_to') || searchParams.get('redirect');\n\n if (redirectTo) {\n if (isLocalPath(redirectTo)) {\n return redirect(redirectTo);\n } else {\n console.warn(\n `Cross-domain redirects are not supported. Tried to redirect from ${redirectFrom} to ${redirectTo}`,\n );\n }\n }\n } catch (error) {\n console.error(\n `Failed to fetch redirects from Storefront API for route ${redirectFrom}`,\n error,\n );\n }\n\n return response;\n}"
},
"StorefrontRedirect": {
"filePath": "/routing/redirect.ts",
"syntaxKind": "TypeAliasDeclaration",
"name": "StorefrontRedirect",
"value": "{\n storefront: Storefront<I18nBase>;\n request: Request;\n response?: Response;\n}",
"value": "{\n /** The [Storefront client](/docs/api/hydrogen/2023-04/utilities/createstorefrontclient) instance */\n storefront: Storefront<I18nBase>;\n /** The [MDN Request](https://developer.mozilla.org/en-US/docs/Web/API/Request) object that was passed to the `server.ts` request handler. */\n request: Request;\n /** The [MDN Response](https://developer.mozilla.org/en-US/docs/Web/API/Response) object created by `handleRequest` */\n response?: Response;\n /** By default the `/admin` route is redirected to the Shopify Admin page for the current storefront. Disable this redirect by passing `true`. */\n noAdminRedirect?: boolean;\n}",
"description": "",
"members": [
{
"filePath": "/routing/redirect.ts",
"syntaxKind": "PropertySignature",
"name": "storefront",
"value": "Storefront<I18nBase>",
"description": ""
"description": "The [Storefront client](/docs/api/hydrogen/2023-04/utilities/createstorefrontclient) instance"
},
{
"filePath": "/routing/redirect.ts",
"syntaxKind": "PropertySignature",
"name": "request",
"value": "Request",
"description": ""
"description": "The [MDN Request](https://developer.mozilla.org/en-US/docs/Web/API/Request) object that was passed to the `server.ts` request handler."
},
{
"filePath": "/routing/redirect.ts",
"syntaxKind": "PropertySignature",
"name": "response",
"value": "Response",
"description": "",
"description": "The [MDN Response](https://developer.mozilla.org/en-US/docs/Web/API/Response) object created by `handleRequest`",
"isOptional": true
},
{
"filePath": "/routing/redirect.ts",
"syntaxKind": "PropertySignature",
"name": "noAdminRedirect",
"value": "boolean",
"description": "By default the `/admin` route is redirected to the Shopify Admin page for the current storefront. Disable this redirect by passing `true`.",
"isOptional": true
}
]
Expand Down
10 changes: 10 additions & 0 deletions packages/hydrogen/src/routing/redirect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@ import type {UrlRedirectConnection} from '@shopify/hydrogen-react/storefront-api
import type {I18nBase, Storefront} from '../storefront';

type StorefrontRedirect = {
/** The [Storefront client](/docs/api/hydrogen/2023-04/utilities/createstorefrontclient) instance */
storefront: Storefront<I18nBase>;
/** The [MDN Request](https://developer.mozilla.org/en-US/docs/Web/API/Request) object that was passed to the `server.ts` request handler. */
request: Request;
/** The [MDN Response](https://developer.mozilla.org/en-US/docs/Web/API/Response) object created by `handleRequest` */
response?: Response;
/** By default the `/admin` route is redirected to the Shopify Admin page for the current storefront. Disable this redirect by passing `true`. */
noAdminRedirect?: boolean;
};

/**
Expand All @@ -22,12 +27,17 @@ export async function storefrontRedirect(
const {
storefront,
request,
noAdminRedirect,
response = new Response('Not Found', {status: 404}),
} = options;

const {pathname, search} = new URL(request.url);
const redirectFrom = pathname + search;

if (pathname === '/admin' && !noAdminRedirect) {
return redirect(`${storefront.getShopifyDomain()}/admin`);
}

try {
const {urlRedirects} = await storefront.query<{
urlRedirects: UrlRedirectConnection;
Expand Down