[REFACTORING] Updating the Tailwind configuration file with a new dynamic opacity placeholder for colors #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blanklob
changed the title
frandiox
requested changes
May 8, 2023
There was a problem hiding this comment.
Hi, thanks for this update! I like this format more than the previous one 👍
Can you add a changeset to this PR (make sure the project is set to "demo-store") and check the change request comment below?
Comment on lines
10
to
13
| primary: 'rgba(var(--color-primary), <alpha-value>)', | ||
| contrast: 'rgba(var(--color-contrast), <alpha-value>)', | ||
| notice: 'rgba(var(--color-accent), <alpha-value>)', | ||
| shopPay: 'rgba(var(--color-shop-pay), <alpha-value>)', |
There was a problem hiding this comment.
rgba seems to be considered legacy and it doesn't work for me in the current version of Tailwind. It works with the modern rgb, though.
Suggested change
| primary: 'rgba(var(--color-primary), <alpha-value>)', | |
| contrast: 'rgba(var(--color-contrast), <alpha-value>)', | |
| notice: 'rgba(var(--color-accent), <alpha-value>)', | |
| shopPay: 'rgba(var(--color-shop-pay), <alpha-value>)', | |
| primary: 'rgb(var(--color-primary) / <alpha-value>)', | |
| contrast: 'rgb(var(--color-contrast) / <alpha-value>)', | |
| notice: 'rgb(var(--color-accent) / <alpha-value>)', | |
| shopPay: 'rgb(var(--color-shop-pay) / <alpha-value>)', |
There was a problem hiding this comment.
Great, and thanks just made the requested changes.
frandiox
approved these changes
May 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
These changes are being implemented to update the Tailwind configuration to include the new opacity color modifier, the special
<alpha-value>placeholder. This will involve removing the old implementation with thewithOpacityfunction. The new implementation will allow for greater customization and flexibility in the config. Additionally, this change will ensure that the project remains up-to-date with the latest tailwind standards.WHAT is this pull request doing?
This PR remove the old implementation with the
withOpacityfunction in thetailwind.config.jsfile and replaces it with the the new<alpha-value>placeholder.HOW to test your changes?
tailwind.config.jsis valid during development in the demo store template.Post-merge steps
Checklist