Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Amendments to how .json and .liquid templates are handled with the same name #5434

Open
rcasimmons opened this issue Feb 19, 2025 · 1 comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Enhancement New feature or request

Comments

@rcasimmons
Copy link

What area(s) will this request affect?

Theme

What type of change do you want to see?

Substantial change to existing feature

Overview

When dealing with a client store whereby branch templates haven't been fully upgraded to 2.0, there's often an issue we encounter where the following will happen:

  1. Open the project in 'main' (this contains index.json and product.liquid)
  2. We branch from this, complete the feature and allow the client to approve and we go live via a PR.
  3. If we then switch to another branch (this contains index.liquid and product.json) that contains legacy templates or whereby we've incrementally upgraded the templates, CLI refuses to upload them as they exist and we end up with a 404 for those templates resulting us in either having to delete the remote development theme or resaving the new template.

A flag to force overwriting of templates would be nice to have or alt. maybe a prompt to simply ask as opposed to refusing point blank.

Motivation

With deadlines and how things work, it's proving difficult to simply cherry pick the 2.0 work into legacy branches meaning we constantly have this battle of templates 404'ing due to CLI refusing to overwrite the template.

A flag or question when this issue occurs would be nice to have.

@rcasimmons rcasimmons added the Type: Enhancement New feature or request label Feb 19, 2025
@gonzaloriestra gonzaloriestra added the Area: @shopify/theme @shopify/theme package issues label Feb 20, 2025
@jamesmengo
Copy link
Contributor

Hey @rcasimmons!

Thanks for this suggestion - I think this is a valid idea, so I'll bring this to the team. There may be some platform considerations / reasons here that we would need to explore, but feel free to be loud about this, and to check in / bump this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants