v2.4 changelog edited, permissions in MapsActivity fixed, release

Author: Seva-coder

ChangeLog.txt

@@ -1,3 +1,9 @@
+v2.4
+- for gps- and wifi requests added timestamp to SMS
+- permissions requests only when they really need (now all permissions are not requested during the start)
+- services for searching now are "foreground" (should increase reliability)
+- fixes in Spanish translation
+
 v2.3
 - new feature: ringing by request, even if sound muted (only from trusted numbers)
 

app/build.gradle

@@ -6,8 +6,8 @@ android {
         applicationId "ru.seva.finder"
         minSdkVersion 17
         targetSdkVersion 26
-        versionCode 14
-        versionName "2.3"
+        versionCode 15
+        versionName "2.4"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true
         project.ext.set("archivesBaseName", "Finder" + defaultConfig.versionName)

app/src/main/AndroidManifest.xml

@@ -15,7 +15,6 @@
     <uses-permission android:name="android.permission.READ_PHONE_STATE" />
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.ACCESS_NOTIFICATION_POLICY" />
-    <uses-permission android:name="android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" />
     <!--
     The following permission is needed for automatically activate GPS
     but this requires grant via ADB first.

app/src/main/java/ru/seva/finder/GpsSearch.java

@@ -187,7 +187,7 @@ public int onStartCommand(Intent intent, int flags, int startId) {
             //on new API no permission or GPS disabled
             if ((Build.VERSION.SDK_INT >=23 && getApplicationContext().checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION) == PackageManager.PERMISSION_DENIED) ||
                     !locMan.isProviderEnabled(LocationManager.GPS_PROVIDER)) {
-                sms_answer.append("gps not enabled");
+                sms_answer.append("gps not enabled\n");
                 start_send();
             }
 
@@ -232,7 +232,7 @@ public void run() {
                 sms_answer.append(gen_short_osm_url(lastLocation.getLatitude(), lastLocation.getLongitude(), OSM_ZOOM));
                 sms_answer.append("\n");
             } else {
-                sms_answer.append("unable get location");
+                sms_answer.append("unable get location\n");
             }
             start_send();
         }

app/src/main/java/ru/seva/finder/MainActivity.java

@@ -577,14 +577,15 @@ private void sendMyGpsCoord() {
      * @param requestCode
      */
     private void requirePermissions(@NonNull String[] requiredPerm, int requestCode) {
-        //request missing permissions for tracking
+        //request missing permissions
         ArrayList<String> lacking = new ArrayList<>();
         if (requiredPerm.length == 0) return;
         for (String permission : requiredPerm) {
             if (ContextCompat.checkSelfPermission(getApplicationContext(), permission) == PackageManager.PERMISSION_DENIED) {
                 lacking.add(permission);
             }
         }
+        if (lacking.size() == 0) return;
         ActivityCompat.requestPermissions(MainActivity.this, lacking.toArray(new String[0]), requestCode);
     }
 

app/src/main/java/ru/seva/finder/MapsActivity.java

@@ -121,11 +121,10 @@ public void onCreate(Bundle savedInstanceState) {
 
         //receiver to map updating
         LocalBroadcastManager.getInstance(this).registerReceiver(updMap, new IntentFilter("update_map"));
-
-        if (Build.VERSION.SDK_INT >= 23 && ContextCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) == PackageManager.PERMISSION_DENIED) {
-            ActivityCompat.requestPermissions(this, new String[] {Manifest.permission.ACCESS_FINE_LOCATION}, 1);
+        if (Build.VERSION.SDK_INT >= 23) {
+            requirePermissions(new String[]{Manifest.permission.ACCESS_FINE_LOCATION, Manifest.permission.WRITE_EXTERNAL_STORAGE}, 1);
+        }
         }
-    }
 
     public void onResume() {
         super.onResume();
@@ -143,6 +142,19 @@ public void onDestroy() {
         super.onDestroy();
     }
 
+    private void requirePermissions(@NonNull String[] requiredPerm, int requestCode) {
+        //request missing permissions
+        ArrayList<String> lacking = new ArrayList<>();
+        if (requiredPerm.length == 0) return;
+        for (String permission : requiredPerm) {
+            if (ContextCompat.checkSelfPermission(getApplicationContext(), permission) == PackageManager.PERMISSION_DENIED) {
+                lacking.add(permission);
+            }
+        }
+
+        if (lacking.size() == 0) return;
+        ActivityCompat.requestPermissions(MapsActivity.this, lacking.toArray(new String[0]), requestCode);
+    }
 
     private void trackRedraw() {
         Cursor query =  db.query("tracking_table", new String[] {"_id", "lat", "lon", "speed", "date"}, "track_id = ?", new String[] {String.valueOf(track_id)}, null, null, "_id ASC");
@@ -182,8 +194,11 @@ public void onReceive(Context context, Intent intent) {
     };
 
     public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
-        if (grantResults[0] == PackageManager.PERMISSION_DENIED) {
-            Toast.makeText(this, R.string.no_permits_received, Toast.LENGTH_SHORT).show();
+        for (int perm : grantResults) {
+            if (perm == PackageManager.PERMISSION_DENIED) {
+                Toast.makeText(this, R.string.no_permits_received, Toast.LENGTH_SHORT).show();
+                break;
+            }
         }
     }
 

fastlane/metadata/android/en-US/changelogs/15.txt

@@ -0,0 +1,5 @@
+v2.4
+- for gps- and wifi requests added timestamp to SMS
+- permissions requests only when they really need (now all permissions are not requested during the start)
+- services for searching now are "foreground" (should increase reliability)
+- fixes in Spanish translation

fastlane/metadata/android/ru-RU/changelogs/15.txt

@@ -0,0 +1,5 @@
+v2.4
+- в ответное SMS добавлена метка времени (для поиска gps- и wifi)
+- теперь запрашиваются только те права, котрые необходимы для данных настроек (не все подряд при первом же страте)
+- сервисы для поиска (gps/wifi) теперь "foreground" (должно улучшить надёжность - android не завершит их в фоне)
+- исправления в испанском переводе