Override the default product variant prices calculator to use our implementation instead

Author: loevgaard

src/Checker/PreQualification/CompositePreQualificationChecker.php

@@ -1,10 +1,9 @@
 <?php
-declare(strict_types=1);
 
+declare(strict_types=1);
 
 namespace Setono\SyliusCatalogPromotionPlugin\Checker\PreQualification;
 
-
 use Setono\CompositeCompilerPass\CompositeService;
 use Setono\SyliusCatalogPromotionPlugin\Model\ProductInterface;
 use Setono\SyliusCatalogPromotionPlugin\Model\PromotionInterface;
@@ -14,7 +13,6 @@
  */
 final class CompositePreQualificationChecker extends CompositeService implements PreQualificationCheckerInterface
 {
-
     public function isPreQualified(ProductInterface $product, PromotionInterface $catalogPromotion): bool
     {
         foreach ($this->services as $service) {

src/Checker/PreQualification/RulesPreQualificationChecker.php

@@ -1,15 +1,15 @@
 <?php
-declare(strict_types=1);
 
+declare(strict_types=1);
 
 namespace Setono\SyliusCatalogPromotionPlugin\Checker\PreQualification;
 
-
 use Setono\SyliusCatalogPromotionPlugin\Checker\PreQualification\Rule\RuleCheckerInterface;
 use Setono\SyliusCatalogPromotionPlugin\Model\ProductInterface;
 use Setono\SyliusCatalogPromotionPlugin\Model\PromotionInterface;
 use Setono\SyliusCatalogPromotionPlugin\Model\PromotionRuleInterface;
 use Sylius\Component\Registry\ServiceRegistryInterface;
+use Webmozart\Assert\Assert;
 
 final class RulesPreQualificationChecker implements PreQualificationCheckerInterface
 {
@@ -34,8 +34,9 @@ public function isPreQualified(ProductInterface $product, PromotionInterface $ca
 
     private function isEligibleToRule(ProductInterface $product, PromotionRuleInterface $rule): bool
     {
-        /** @var RuleCheckerInterface $checker */
-        $checker = $this->ruleRegistry->get($rule->getType());
+        /** @var RuleCheckerInterface|object $checker */
+        $checker = $this->ruleRegistry->get((string) $rule->getType());
+        Assert::isInstanceOf($checker, RuleCheckerInterface::class);
 
         return $checker->isEligible($product, $rule->getConfiguration());
     }

src/DependencyInjection/Compiler/OverrideProductVariantPricesCalculatorPass.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Setono\SyliusCatalogPromotionPlugin\DependencyInjection\Compiler;
+
+use Setono\SyliusCatalogPromotionPlugin\Calculator\ProductVariantPricesCalculator;
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+/**
+ * This plugin has its own implementation of the \Sylius\Component\Core\Calculator\ProductVariantPricesCalculatorInterface
+ * and hence we will override the default service with our own implementation.
+ */
+final class OverrideProductVariantPricesCalculatorPass implements CompilerPassInterface
+{
+    public function process(ContainerBuilder $container): void
+    {
+        if (!$container->has('sylius.calculator.product_variant_price')) {
+            return;
+        }
+
+        $container->setAlias('sylius.calculator.product_variant_price', ProductVariantPricesCalculator::class);
+    }
+}

src/SetonoSyliusCatalogPromotionPlugin.php

@@ -7,6 +7,7 @@
 use Setono\CompositeCompilerPass\CompositeCompilerPass;
 use Setono\SyliusCatalogPromotionPlugin\Checker\PreQualification\CompositePreQualificationChecker;
 use Setono\SyliusCatalogPromotionPlugin\Checker\Runtime\CompositeRuntimeChecker;
+use Setono\SyliusCatalogPromotionPlugin\DependencyInjection\Compiler\OverrideProductVariantPricesCalculatorPass;
 use Setono\SyliusCatalogPromotionPlugin\DependencyInjection\Compiler\RegisterRulesAndRuleCheckersPass;
 use Sylius\Bundle\CoreBundle\Application\SyliusPluginTrait;
 use Sylius\Bundle\ResourceBundle\AbstractResourceBundle;
@@ -29,6 +30,7 @@ public function build(ContainerBuilder $container): void
         parent::build($container);
 
         $container->addCompilerPass(new RegisterRulesAndRuleCheckersPass());
+        $container->addCompilerPass(new OverrideProductVariantPricesCalculatorPass());
         $container->addCompilerPass(new CompositeCompilerPass(CompositePreQualificationChecker::class, 'setono_sylius_catalog_promotion.pre_qualification_checker'));
         $container->addCompilerPass(new CompositeCompilerPass(CompositeRuntimeChecker::class, 'setono_sylius_catalog_promotion.runtime_checker'));
     }

tests/Application/config/packages/_sylius.yaml

@@ -13,8 +13,7 @@ sylius_shop:
 
 sylius_api:
     enabled: true
-    
-    
+
 sylius_product:
     resources:
         product: