Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultWebPath handles plural not correctly #30

Closed
HCoban opened this issue Mar 30, 2018 · 1 comment
Closed

defaultWebPath handles plural not correctly #30

HCoban opened this issue Mar 30, 2018 · 1 comment

Comments

@HCoban
Copy link

HCoban commented Mar 30, 2018 •
edited
Loading

Shouldn't below conditional return the opposite like

isPlural ? "commits" : "commit"

Currently it is

vscode-gitblame/src/git/blame.ts

Line 123 in f1a17b6

`https://$2/$3/${isPlural ? "commit" : "commits"}/${hash}`,

If this was a mistake I can make a pull request and fix it. Thanks
@Sertion
Copy link
Owner

Sertion commented Mar 30, 2018

Nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sertion @HCoban