potential null pointer dereference in DeviceRotation.java

[HermioneSW]

🐛 Bug Report

A clear and concise description of what the bug is.

In DeviceRotation.java (/java/client/src/org/openqa/selenium/DeviceRotation.java), line 52 DeviceRotation function when map is null at line 53, the if body will be executed which will trigger a bug in map.toString() at line 55.

To Reproduce

Detected by our static analysis tool.

Expected behavior

null pointer is not thrown

Test script or set of commands reproducing this issue

Again it's detected our static analysis algorithm

Environment

Any environment

We are developing a new static analysis tool for catching bugs in Java code. Would you please take a look and confirm this is indeed a bug? Thanks a million!!!

[HermioneSW]

@AutomatedTester similar to the issue #8185, would you please double check this one as well.

[HermioneSW]

@AutomatedTester and @barancev can either of you reopen issue and hopefully fix it. We believe the problem is similar to the issue #8185. Thanks so much!

[barancev]

The issue has been fixed, see 92240ce and dd47b12

[HermioneSW]

@barancev thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.