Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement T3 r-z helix chi2 cuts (rebase PR92) #131

Conversation

ariostas
Copy link
Member

This is a rebase of PR #92. It wasn't similar to other PRs and it changes the performance plots a bit, so I made it its own rebase PR.

Co-authored-by: Chris Hoang <dhhoang@ucsd.edu>
@ariostas ariostas requested a review from bucket420 November 25, 2024 16:20
@bucket420
Copy link

Looks good to me (sorry about the late response)

@ariostas
Copy link
Member Author

ariostas commented Dec 2, 2024

/run all

Copy link

github-actions bot commented Dec 2, 2024

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     43.2    384.7    184.4    128.2    135.9    504.9    107.6    253.2    136.1      3.5    1881.6    1333.6+/- 374.2     498.6   explicit[s=4] (target branch)
   avg     40.8    384.6    184.2    151.4    182.5    509.7    116.1    233.5    145.8      3.3    1951.9    1401.3+/- 393.2     518.7   explicit[s=4] (this PR)

Copy link

github-actions bot commented Dec 2, 2024

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@bucket420 bucket420 merged commit 8c9753d into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch1_devel_rebased Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants