Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully optional false_easting/_northings for all coord systems #3629

Closed
trexfeathers opened this issue Jan 8, 2020 · 2 comments · Fixed by #3804
Closed

Fully optional false_easting/_northings for all coord systems #3629

trexfeathers opened this issue Jan 8, 2020 · 2 comments · Fixed by #3804

Comments

@trexfeathers
Copy link
Contributor

As first highlighted in #3626, false_easting and false_northing arguments can be supplied as =None if they are absent from the loaded data. To handle =None for these arguments, an Iris coord system needs to have None as the default value, rather than the 0 supplied in most current cases.

It has been confirmed that these arguments are always optional under the CF conventions. Therefore: the modifications and tests already written for the Geostationary coord system in #3628 should be mirrored for all coordinate systems that include false_easting and false_northing arguments.

@pp-mo
Copy link
Member

pp-mo commented Jan 8, 2020

It has been confirmed that these arguments are always optional under the CF conventions.

Wellll, not quite .. not till it is agreed + merged !

@marqh
Copy link
Member

marqh commented Jan 9, 2020

It has been confirmed that these arguments are always optional under the CF conventions.

Wellll, not quite .. not till it is agreed + merged !

I agree, but the community buy in pretty good on this one; hopefully we'll have it merged soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants