Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show seekbar tooltip info while dragging #306

Closed
Keith94 opened this issue Jan 11, 2025 · 9 comments · Fixed by #338
Closed

Always show seekbar tooltip info while dragging #306

Keith94 opened this issue Jan 11, 2025 · 9 comments · Fixed by #338
Labels
feature request New feature or request

Comments

@Keith94
Copy link
Contributor

Keith94 commented Jan 11, 2025

Expected behavior of the wanted feature

Current behavior

  1. Put bottomhover=no
  2. Click and hold seekbar handle
  3. Move mouse above the seekbar
  4. Move mouse left/right

All seekbar information (thumbnail, time stamp, chapter title) disappears unless you're hovering the seek handle.

Desired behavior

Keep all seekbar information prominent even if mouse cursor drifts off the handle while dragging.

@Keith94 Keith94 added the feature request New feature or request label Jan 11, 2025
@Samillion

This comment has been minimized.

@Keith94

This comment has been minimized.

@Keith94
Copy link
Contributor Author

Keith94 commented Jan 25, 2025

It mostly works well (way better than current behavior) but with a couple glitches like the one you mentioned:

Most likely will show thumbnails with volume bar as well

There's another glitch, if you drag the progress bar to the beginning or end of the file, click and drag the maximize button, the thumbnail will show up.

mpv_9ca9zhdBFY.mp4

@Samillion

This comment has been minimized.

@Samillion

This comment has been minimized.

@Keith94

This comment has been minimized.

@Samillion
Copy link
Owner

Samillion commented Feb 1, 2025

Test script: force_tooltip/modernz.lua
Commit: 3f4ea4b

# modernz.conf
# enable the option to force seek tooltip
force_seek_tooltip=yes

Changes:

  • Add force_seek_tooltip option
  • Rename playingWhilstSeeking state to playing_and_seeking
  • Rename persistentprogresstoggle state to persistent_progress_toggle
  • Remove unused state playingWhilstSeekingWaitingForEnd
  • Make playing_and_seeking state independent and not tied to mouse_seek_pause option
  • Fix behavior of mouse_seek_pause option when set to no and mouse drag then release mouse button
    • It used to pause the video on button release, now it doesn't
    • Now it only cycles pause if mouse_seek_pause is set to yes

@Keith94
Copy link
Contributor Author

Keith94 commented Feb 1, 2025

That is brilliant ! Great job and thank you so much. :)

@Samillion
Copy link
Owner

My pleasure. I won't merge immediately, just in case an unexpected behavior shows up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants