Merge pull request #7281 from SalesforceFoundation/feature/256__W-17898954-checkbox-value-error-on-gift-entry

W-17898954 - checkbox validation error on gift entry

Author: lparrott

force-app/main/default/classes/BDI_DataImportService.cls

@@ -2266,7 +2266,7 @@ global with sharing class BDI_DataImportService {
 
         for (String diField : diFieldToTargetFieldMap.keySet()){
             // Set the is populated flag to true if the field should not be ignored, and it does have a value in the DI
-            Boolean shouldAddPopulatedField = !fieldsToIgnore.contains(diField.toLowerCase()) && di.get(diField) != null;
+            Boolean shouldAddPopulatedField = !fieldsToIgnore.contains(diField.toLowerCase()) && di.get(diField) != null && di.get(diField) != false;
             if (shouldAddPopulatedField) {
                 isPopulated = true;
                 break;

force-app/main/default/lwc/geBatchWizard/geBatchWizard.js

@@ -68,6 +68,7 @@ export default class geBatchWizard extends NavigationMixin(LightningElement) {
     @track hasInvalidBatchFields = false;
     @track missingBatchHeaderFieldLabels = [];
     @track missingRequiredFieldsMessage;
+    @track allowFirstInstallment = false;
 
     dataImportBatchFieldInfos;
     dataImportBatchInfo;
@@ -90,7 +91,6 @@ export default class geBatchWizard extends NavigationMixin(LightningElement) {
         third: 2
     }
 
-    _allowFirstInstallment = false;
     _allowFirstInstallmentDisabled;
     _allowRecurringDonations = false;
 
@@ -119,28 +119,16 @@ export default class geBatchWizard extends NavigationMixin(LightningElement) {
         const isChecked = event.detail.value
         this._allowRecurringDonations = isChecked;
         if (!isChecked) {
-            this._allowFirstInstallment = false;
+            this.allowFirstInstallment = false;
             this._allowFirstInstallmentDisabled = true;
         } else {
             this._allowFirstInstallmentDisabled = false;
         }
 
     }
 
-    get allowFirstInstallment () {
-        if (this.isEditMode && this._allowRecurringDonations) {
-            let batchLevelDefaults =
-                JSON.parse(this.dataImportBatchRecord.fields[DATA_IMPORT_BATCH_DEFAULTS_INFO.fieldApiName].value);
-            return batchLevelDefaults['AllowFirstInstallment__f'] ? 
-                batchLevelDefaults['AllowFirstInstallment__f'].value : 
-                false;
-        }
-
-        return this._allowFirstInstallment;
-    }
-
     handleAllowFirstInstallmentOnChange(event) {
-        this._allowFirstInstallment = event.detail.value;
+        this.allowFirstInstallment = event.detail.value;
     }
 
     get allowFirstInstallmentDisabled() {
@@ -272,9 +260,17 @@ export default class geBatchWizard extends NavigationMixin(LightningElement) {
             ?.fields[DATA_IMPORT_BATCH_ALLOW_RECURRING_DONATIONS.fieldApiName]
             ?.value;
 
+        if (!this._allowRecurringDonations) {
+            this._allowFirstInstallmentDisabled = true;
+        }
+
         let batchLevelDefaults =
             JSON.parse(this.dataImportBatchRecord.fields[DATA_IMPORT_BATCH_DEFAULTS_INFO.fieldApiName].value);
 
+        this.allowFirstInstallment = batchLevelDefaults['AllowFirstInstallment__f'] ? 
+            batchLevelDefaults['AllowFirstInstallment__f'].value : 
+            false;
+
         this.formSections.forEach(section => {
             if (section.elements) {
                 section.elements.forEach(element => {

force-app/main/default/lwc/geFormRenderer/geFormRenderer.js

@@ -2651,11 +2651,14 @@ export default class GeFormRenderer extends LightningElement{
             ? this.CUSTOM_LABELS.geTextUpdating
             : this.CUSTOM_LABELS.geTextSaving;
         delete dataImportFromFormState[apiNameFor(PAYMENT_AUTHORIZE_TOKEN)];
+        const dataImportfieldsInfo = this.dataImportObjectInfo?.data?.fields || {};
         Object.keys(dataImportFromFormState).forEach((field)=>{
-            if(dataImportFromFormState[field] === undefined) {
-                dataImportFromFormState[field] = null;
+            if (dataImportfieldsInfo[field]?.dataType === 'Boolean' && dataImportFromFormState[field] === undefined) {
+                dataImportFromFormState[field] = false;
+            } else {
+                dataImportFromFormState[field] ??= null;
             }
-        })
+        });
         const upsertResponse = await upsertDataImport({
             dataImport: JSON.stringify(dataImportFromFormState)
         });

force-app/main/default/lwc/geListView/geListView.js

@@ -287,14 +287,12 @@ export default class geListView extends LightningElement {
 
         this.isLoading = false;
 
-        console.log('Test 1');
         let style = document.createElement('style');
         style.innerText = '.slds-table_header-fixed_container{border: 1px solid red;}';
         let dt = this.template.querySelector('lightning-datatable');
         if(dt) {
             dt.appendChild(style);
         }
-        console.log('Test 2');
     }
 
     /*******************************************************************************