fix(form): replace use of context to apply field spacing #7243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where margin-bottom applied to Textbox based components would not be applied to character count.
The use of form spacing context to apply spacing to our inputs within Form has caused issues for consumers using it in exported components in different projects using Carbon. This fix replaces context with a pure css solution to ensure margins are applied and consistent across projects. fix #7058
Parsium
reviewed
Mar 10, 2025
|
|
||
| When `fieldSpacing` prop is given a value, the vertical spacing between the form fields is changed (margin bottom on each field), the value of the prop multiplied by the base theme `8px` spacing value. The default is value `3` which is therefore `24px`. This can be overriden on a specific field if needed. | ||
| You can use the `fieldSpacing` prop to set the spacing between fields within `Form`, which will add a margin-bottom to supported input components. |
There was a problem hiding this comment.
praise: this is much clearer to read!
damienrobson-sage
approved these changes
Mar 12, 2025
Parsium
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7058
Proposed behaviour
FormSpacingcontext with css only solution to ensure margins are applied across projects.Textboxreceives margin.Current behaviour
FormusesFormSpacingcontext to apply spacing to vertically separate inputs. This causes issues for consumers usingFormin exported components, as the spacing is not applied across projects.Textbox.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions