fix: subtype check for literal and union types (part 2) #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 114 114
Lines 12805 12811 +6
Branches 4208 4212 +4
=======================================
+ Hits 12770 12776 +6
Misses 35 35 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
Jan 4, 2025
## [0.23.0](v0.22.0...v0.23.0) (2025-01-04) ### Features * categorize API elements ([#1285](#1285)) ([3275900](3275900)), closes [#1243](#1243) * optional error messages for constraints ([#1275](#1275)) ([fce761c](fce761c)), closes [#1082](#1082) * prevent editing built-in stubs ([#1282](#1282)) ([d02c30a](d02c30a)) * show placeholders in outline ([#1286](#1286)) ([3880bfe](3880bfe)) ### Bug Fixes * subtype check for literal and union types ([#1288](#1288)) ([911881c](911881c)) * subtype check for literal and union types (part 2) ([#1289](#1289)) ([56284cf](56284cf)) * type inference for lambdas and their parameters ([#1304](#1304)) ([a9e070f](a9e070f))
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The type checker previously did not regard
literal<1, "">as a subtype ofunion<literal<1>, literal<"">. This is fixed now.