Make sure config value is used when showing bubble #77
Conversation
|
Here is the solution guys, less work for you... and no offense but since this is an issue since 2019 I might as well do it myself.
Now the bool argument will correctly identify false in your user settings. The issue was the first implementation always considered result as true except empty arguments. |
|
@ekleop will have some time to merge and recheck after March 3rd. The update to kodi repo should take about 2-8 weeks to be approved. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request addresses issues #76 and #55 by ensuring that the configuration value for the bubble notification is correctly interpreted as a boolean. The change involves converting the setting value to lowercase and checking if it's either 'true' or '1'. This approach enhances the reliability of the bubble notification feature.
Summary of Findings
Merge Readiness
The code change appears to correctly address the issue. The use of .lower() and checking against both 'true' and '1' makes the condition more robust. Since there are no comments, I would recommend that this be merged. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
Fixes #76 and #55