fix(ui5-proxy-middleware): support usage inside connect servers #1224

petermuessig · 2023-08-27T20:04:31Z

When using the dev-approuter (https://www.npmjs.com/package/dev-approuter) to run UI5 and CAP applications inside the @sap/router from a monorepo then the server is using connect and not express. In those scenarios, similar like with livereload only the basic http response object from Node.js is available and the status function is not available which leads to an INTERNAL SERVER ERROR. By using the writeHead, write and end function of the response object the function is agnostic to the used server and works in both scenarios.

changeset-bot · 2023-08-27T20:04:35Z

🦋 Changeset detected

Latest commit: 6e4134a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sap-ux/ui5-proxy-middleware	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cla-assistant · 2023-08-27T20:04:46Z

All committers have signed the CLA.

petermuessig · 2023-08-27T20:09:48Z

Hi @zdravko-georgiev ,

please get in touch with @nicoschoenteich - he has the project setup for this new dev-approuter with which you can also validate the fix. I tested it locally by manually fixing it in the node_modules.

BTW: when you search for res.status in this repo, you can find additional places which may have issues in such connect scenarios: adp-tooling, preview-middleware. They are not required to be fixed for now - but just FYI. It would be great to get this one fixed, so that the proxy-middleware can be used with the dev-approuter.

Thanks a lot... 😄

When using the dev-approuter (https://www.npmjs.com/package/dev-approuter) to run UI5 and CAP applications inside the @sap/router from a monorepo then the server is using connect and not express. In those scenarios, similar like with livereload only the basic http response object from Node.js is available and the status function is not available which leads to an INTERNAL SERVER ERROR. By using the writeHead, write and end function of the response object the function is agnostic to the used server and works in both scenarios.