feat(adaptation-project): Add Fragment enhancement #1183
Merged
+1,854
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bb106ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
…controller-enhancement
…controller-enhancement
…controller-enhancement
tobiasqueck
reviewed
Sep 18, 2023
packages/preview-middleware-client/test/unit/adp/controllers/AddFragment.controller.test.ts
Outdated
Show resolved
Hide resolved
tobiasqueck
previously approved these changes
Sep 19, 2023
There was a problem hiding this comment.
- changeset ok
- code is understandable
- test coverage is very good
- there are few minor things that could be improved in the tests but testing the client-side code is something very new in this repo, so I expect that we will revisit the tests anyhow in the near future
- locally tested and works like a charm
tobiasqueck
approved these changes
Sep 20, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing the preview-middleware with new functionality as adding an XML Fragment (*creating "addXML" change).
Added the following new node_modules to the adp-tooling package:
sanitize-filename: To sanitize user-provided input and prevent accessing unwanted files, by injecting path-like strings as input.