Allow loading RTA plugins for adaptation projects #1166
Conversation
|
…P/open-ux-tools into feat/1149/enable-enhancements
tobiasqueck
changed the title
| const files = await this.project.byGlob('/**/changes/**/*.fragment.xml'); | ||
| try { | ||
| const names = files.map((file) => file.getPath()); | ||
| res.status(200).contentType('application/json').send(JSON.stringify(names)); |
There was a problem hiding this comment.
Based on #1224 Shouldn't we use here also writeHead, write and end?
|
Also I am getting the following error for |
packages/adp-tooling/package.json
Outdated
| @@ -14,7 +14,9 @@ | |||
| "author": "@SAP/ux-tools-team", | |||
| "main": "dist/index.js", | |||
| "scripts": { | |||
| "build": "tsc --build", | |||
| "build": "pnpm build:server && pnpm build:client", | |||
There was a problem hiding this comment.
could use npm-run-all -l -p to run these in parallel.
There was a problem hiding this comment.
Move to separate writer module?
There was a problem hiding this comment.
I would say no as explained at #1166 (comment)
|
Is babel actually sufficient in this case? It only transpiles and usually all code that gets consumed by browser needs to be bundled for performance reasons. |
I'd say it is sufficient because it is a development module and while there might be a measurable performance issue I doubt that it is perceivable for a human being. |
Combining server and writer is actually independent of this PR and happened a while ago. The main reason is the reuse of the functionality in both cases, e.g. adding artifacts like a fragment are planned to be enabled through the middleware and the client running the browser as well as through other interfaces e.g. in guided development or the page modeler. Combining client and server is done because the client is only hosted by this server, i.e. running the very same client by any other server, not offering the APIs is not useful. |
that is the annoying ts server. It sometimes (sometimes not) crashes and then it cannot find the |
|
SonarCloud Quality Gate failed.
|
This PR does not contain a changeset on purpose because the change does not fix a bug or adds any new functionality that is exposed to the consumer. This is a preparation work required to be able to add new features to the
adp-tooling. Once this is merged, PR #1183 will follow right away including a changeset.adt-toolingaddApisfunction allowing to define additional APIs for adaptation project e.g. to read and write fragmentstemplatestotemplates/projectto allow adding other templates for RTApreview-middlewareadt-toolingpreview-middleware-client