Adds missing callback functions in container #4257
Conversation
…://github.com/SAP/luigi into 4249-container-add-missing-callback-functions
walmazacn
requested review from
hardl,
JohannesDoberer,
ndricimrr,
VincentUllal and
smahati
as code owners
There was a problem hiding this comment.
Extending the e2e test setup to check the whole flows could help a lot.
See https://github.com/SAP/luigi/blob/main/container/cypress/e2e/test-app/iframe/iframe-container.cy.js,
,...
| target.postMessage( | ||
| { | ||
| msg: LuigiInternalMessageID.SEND_PATH_EXISTS_ANSWER, | ||
| data: { exists } |
There was a problem hiding this comment.
correlationId in the data object is missing.
Take a look here
LuigiClient expects a correlationId to resolve the correct promise.
| target.postMessage( | ||
| { | ||
| msg: LuigiInternalMessageID.SEND_CURRENT_ROUTE_ANSWER, | ||
| data: { route } |
There was a problem hiding this comment.
correlationId in the data object is missing.
Take a look here.
There was a problem hiding this comment.
In addition I think it would make sense that we extend the current function https://github.com/SAP/luigi/blob/main/container/test-app/iframe/microfrontend.html#L210
using the promise and add a corresponding e2e test.
Same for pathExists
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #4249