Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemStack not fully functional #1

Open
S-S-X opened this issue Nov 21, 2020 · 4 comments · May be fixed by #76
Open

ItemStack not fully functional #1

S-S-X opened this issue Nov 21, 2020 · 4 comments · May be fixed by #76
Labels
enhancement New feature or request WIP Work in progress

Comments

@S-S-X
Copy link
Owner

S-S-X commented Nov 21, 2020

Implement rest of ItemStack:
https://github.com/mt-mods/mineunit/blob/master/itemstack.lua

Basically simply just replace error("NOT IMPLEMENTED") with correctly arranged stream of bytes that will make it do something similar what comments above function signature says.
@S-S-X S-S-X added the enhancement New feature or request label Nov 21, 2020
S-S-X pushed a commit that referenced this issue Nov 23, 2020
(#1, #2) Add or fix some ItemStack, MetaDataRef and Player methods
7e376ad
@S-S-X
Copy link
Owner Author

S-S-X commented Mar 9, 2021

Added bit more stuff in few last commits, ItemStack is near complete.

@S-S-X
Copy link
Owner Author

S-S-X commented Mar 10, 2021

PR #14 implements many missing features but still not complete.
Just ItemStack:get_tool_capabilities(), ItemStack:replace(item) and ItemStack:to_table() missing.

@S-S-X
Copy link
Owner Author

S-S-X commented Sep 8, 2021

#22 introduced simple to_table method. Implementation were not checked against actual engine at all, just quick hack.
It might be correct but most probably it is not following engine implementation exactly. Should be checked.

@S-S-X S-S-X added the good first issue Good for newcomers label Sep 17, 2021
@S-S-X
Copy link
Owner Author

S-S-X commented Oct 22, 2021

#22 introduced simple to_table method. Implementation were not checked against actual engine at all, just quick hack. It might be correct but most probably it is not following engine implementation exactly. Should be checked.

to_table seems to be wrong as I've tried to run mineunit against moreblocks mod and thing crashes trying to read itemstack:get_meta():to_table().fields within core engine item.lua and field does not exist.

Have to fix that, best to actually look at engine implementation this time instead of rolling dice 😄

@S-S-X S-S-X added WIP Work in progress and removed good first issue Good for newcomers labels Nov 23, 2021
@S-S-X S-S-X mentioned this issue Nov 23, 2021
Merged
@S-S-X S-S-X linked a pull request Mar 20, 2022 that will close this issue
Open
@S-S-X S-S-X mentioned this issue Apr 3, 2022
Open
@S-S-X S-S-X added this to Mineunit Jan 11, 2024
@S-S-X S-S-X moved this to Ready in Mineunit Jan 11, 2024
@S-S-X S-S-X moved this from Ready to In review in Mineunit Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request WIP Work in progress
Projects
Mineunit
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ItemStack:get_tool_capabilities / core.get_dig_params S-S-X/mineunit
1 participant
@S-S-X