Update tests

Author: S-S-X

.luacheckrc

@@ -0,0 +1,33 @@
+unused_args = false
+
+-- Exclude regression tests / unit tests
+exclude_files = {
+	"**/core/**",
+	"**/spec/**",
+	"**/demo_spec/**",
+}
+
+globals = {
+	"mineunit", "world",
+	"mineunit_path", "fixture", "fixture_path",
+	"core", "minetest",
+	"vector", "dump","dump2",
+	"default",
+}
+
+read_globals = {
+	-- luassert
+	assert = { fields = {
+		"is_string", "is_table", "player_or_name", "is_ItemStack", "is_Player"
+	}},
+
+	-- Mineunit
+	"mineunit_config", "mineunit_conf_defaults", "mineunit_conf_override",
+	"NodeTimerRef", "MetaDataRef", "NodeMetaRef", "ObjectRef", "InvRef",
+	"DEPRECATED",
+
+	-- Minetest
+	string = {fields = {"split", "trim"}},
+	table = {fields = {"copy", "getn"}},
+	"PseudoRandom", "ItemStack", "VoxelArea", "VoxelManip", "Settings",
+}

mod.conf

@@ -25,7 +25,7 @@ describe("Mineunit assert", function()
 		it("does not accept string", function() assert.error(function() test_assert("SX") end) end)
 		it("does not accept empty arguments", function() assert.error(function() test_assert() end) end)
 		it("does not accept nil", function() assert.error(function() test_assert(nil) end) end)
-		it("accepts ItemStack", function() test_assert(ItemStack()) end)
+		it("accepts ItemStack", function() test_assert(ItemStack(nil)) end)
 	end)
 
 	describe("is_InvRef", function()
@@ -60,7 +60,7 @@ describe("Mineunit assert", function()
 	describe("type override", function()
 
 		it("returns Player as userdata", function() assert.equals("userdata", type(Player())) end)
-		it("returns ItemStack as userdata", function() assert.equals("userdata", type(ItemStack())) end)
+		it("returns ItemStack as userdata", function() assert.equals("userdata", type(ItemStack(nil))) end)
 		it("returns InvRef as userdata", function() assert.equals("userdata", type(InvRef())) end)
 		it("returns InvList as table", function()
 			local inv = InvRef()

spec/assert_spec.lua

@@ -0,0 +1,129 @@
+-- For self tests package path must be set in a way that makes package loaders search current directory first
+package.path = "./?.lua;../?/init.lua;../?.lua;" --.. package.path
+
+describe("Craft API", function()
+
+	require("mineunit")
+	mineunit("core")
+	mineunit("itemstack")
+	mineunit("entity")
+	sourcefile("player")
+	fixture("items")
+
+	local CM = mineunit.CraftManager
+
+	minetest.register_craft({
+		output = 'bridge',
+		recipe = {
+			{'stone', 'stone', 'stone'}
+		}
+	})
+
+	minetest.register_craft({
+		output = 'cross',
+		recipe = {
+			{'stone', 'stone', 'stone'},
+			{'',      'stone', ''},
+			{'',      'stone', ''},
+		}
+	})
+
+	describe("get_all_craft_recipes", function()
+
+		it("returns nil without matches", function()
+			local result = core.get_all_craft_recipes("testunknown")
+			assert.is_nil(result)
+		end)
+
+		it("returns matching recipes", function()
+			local result = core.get_all_craft_recipes("wood")
+			assert.is_table(result)
+		end)
+
+	end)
+
+	describe("get_craft_result", function()
+
+		it("throws without arguments", function()
+			assert.has_error(function() core.get_craft_result() end)
+		end)
+
+		it("throws without without items", function()
+			assert.has_error(function()
+				core.get_craft_result({
+					method = "normal",
+					width = 1,
+				})
+			end)
+		end)
+
+		it("throws without with invalid items", function()
+			assert.has_error(function()
+				core.get_craft_result({
+					method = "normal",
+					width = 1,
+					items = "wood",
+				})
+			end)
+		end)
+
+		it("does not modify input for string items", function()
+			local input = {
+				method = "normal",
+				width = 3,
+				items = {
+					"tree 1"
+				},
+			}
+			local expected_address = tostring(input)
+			local expected_result = table.copy(input)
+			core.get_craft_result(input)
+			-- Compare table address
+			assert.equals(expected_address, tostring(input))
+			assert.same(expected_result, input)
+		end)
+
+		it("does not modify input for ItemStack items", function()
+			local input = {
+				method = "normal",
+				width = 3,
+				items = {
+					ItemStack("tree 1")
+				},
+			}
+			local expected_address = tostring(input)
+			local expected_result = table.copy(input)
+			core.get_craft_result(input)
+			-- Compare table address
+			assert.equals(expected_address, tostring(input))
+			assert.same(expected_result, input)
+		end)
+
+		it("returns results", function()
+			local input = {
+				method = "normal",
+				width = 3,
+				items = {
+					ItemStack("tree 1")
+				},
+			}
+			local expected_result = {
+				time = 0,
+				replacements = {},
+				item = ItemStack("wood 4")
+			}
+			local expected_leftover = {
+				width = 3,
+				items = {
+					ItemStack(nil)
+				},
+				method = "normal"
+			}
+			local result, leftover = core.get_craft_result(input)
+			assert.same(expected_result, result)
+			assert.same(expected_leftover, leftover)
+		end)
+
+	end)
+
+end)

spec/craft_spec.lua

@@ -0,0 +1,116 @@
+core.register_node(":chest", {
+	description = "chest",
+	buildable_to = false,
+	walkable = true,
+	on_construct = function(pos)
+		local meta = core.get_meta(pos)
+		local inv = meta:get_inventory()
+		inv:set_size("chest", 3)
+	end,
+})
+
+core.register_node(":stone", {
+	description = "stone",
+	buildable_to = false,
+	walkable = true,
+	drawtype = "nodebox",
+	node_box = {
+		type = "fixed",
+		fixed = {-0.5, -0.5, -0.5, 0.5, 0.5, 0.5},
+	},
+	collision_box = {
+		type = "fixed",
+		fixed = {-0.5, -0.5, -0.5, 0.5, 0.5, 0.5},
+	},
+	selection_box = {
+		type = "fixed",
+		fixed = {-0.5, -0.5, -0.5, 0.5, 0.5, 0.5},
+	},
+	nodebox = {}
+})
+
+core.register_node(":bridge", {
+	description = "bridge",
+	buildable_to = false,
+	walkable = true,
+	drawtype = "nodebox",
+	node_box = {
+		type = "fixed",
+		fixed = {-0.5, -0.5, -0.5, 0.5, 0.5, 0.5},
+	},
+	collision_box = {
+		type = "fixed",
+		fixed = {-0.5, -0.5, -0.5, 0.5, 0.5, 0.5},
+	},
+	selection_box = {
+		type = "fixed",
+		fixed = {-0.5, -0.5, -0.5, 0.5, 0.5, 0.5},
+	},
+	nodebox = {}
+})
+
+minetest.register_node(":tree", {
+	description = "Apple Tree",
+	tiles = {"tree_top.png", "tree_top.png", "tree.png"},
+	paramtype2 = "facedir",
+	is_ground_content = false,
+	groups = {tree = 1, choppy = 2, oddly_breakable_by_hand = 1, flammable = 2},
+	on_place = minetest.rotate_node
+})
+
+minetest.register_node(":wood", {
+	description = "Apple Wood Planks",
+	paramtype2 = "facedir",
+	place_param2 = 0,
+	tiles = {"wood.png"},
+	is_ground_content = false,
+	groups = {choppy = 2, oddly_breakable_by_hand = 2, flammable = 2, wood = 1},
+})
+
+minetest.register_node(":bush_stem", {
+	description = "Bush Stem",
+	drawtype = "plantlike",
+	visual_scale = 1.41,
+	tiles = {"bush_stem.png"},
+	inventory_image = "bush_stem.png",
+	wield_image = "bush_stem.png",
+	paramtype = "light",
+	sunlight_propagates = true,
+	groups = {choppy = 2, oddly_breakable_by_hand = 1, flammable = 2},
+	selection_box = {
+		type = "fixed",
+		fixed = {-7 / 16, -0.5, -7 / 16, 7 / 16, 0.5, 7 / 16},
+	},
+})
+
+minetest.register_craft({
+	output = "wood 4",
+	recipe = {
+		{"tree"},
+	}
+})
+
+minetest.register_craft({
+	output = "wood",
+	recipe = {
+		{"bush_stem"},
+	}
+})
+
+minetest.register_craft({
+	type = "fuel",
+	recipe = "bush_stem",
+	burntime = 7,
+})
+
+minetest.register_craft({
+	type = "fuel",
+	recipe = "group:wood",
+	burntime = 7,
+})
+
+minetest.register_craft({
+	type = "fuel",
+	recipe = "group:tree",
+	burntime = 30,
+})