Skip to content

slh-dsa: fix benchmark to also run verify_benches() #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

json420
Copy link
Contributor

@json420 json420 commented Mar 22, 2025

The sign_verify.rs benchmark was running the signing benchmarks twice. This fixes that so the verification benchmarks are also run.

@json420
Copy link
Contributor Author

json420 commented Apr 5, 2025

I figured this is probably a good PR to add - run: cargo build --benches --all-features to the github slh-dsa.yml workflow to ensure the slh-dsa benchmarks remain in a buildable state.

I'm not 100% sure I put this line in the best place, so someone with more knowledge of this fancy slh-dsa workflow, please double check and let me know if I should make any changes. Thanks!

@tarcieri tarcieri merged commit 5f44af4 into RustCrypto:master Apr 7, 2025
36 checks passed
@json420 json420 deleted the json420/slh-dsa/benchmarks branch April 7, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants