Ensure backupreader user can make backups #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcooper
reviewed
Jul 20, 2023
| USER backupreader | ||
| RUN mkdir -p /home/backupreader/backups | ||
| RUN mkdir -p /home/backupreader/backups && chown backupreader /home/backupreader/backups | ||
| VOLUME /home/backupreader/backups |
There was a problem hiding this comment.
Will this make backups be stored inside a docker volume?
I think there's a strong case to be made to keep backups outside of the docker ecosystem - as simple files which can be manipulated directly. Also deploy_tool has logic in it for blowing-away volumes, and it's feels to easily to accidentally delete all our backups when tidying up "unused" docker resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to resolve #44