-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Unify voip streams into single stream #25108
Conversation
@d-gubert @amolghode1981 this would be a good addition to the release and forgot to put on milestone 😬 pls don't kill me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some confusion. Hence adding a generic comment. The title says that "Unify voip streams into single stream". When I saw the implementation of "notifyUserInThisInstance", it is using streamUser (
notifyUserInThisInstance(userId: string, eventName: string, ...args: any[]): void { |
Isnt it a single stream? Or Am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review was already done and changes were accepted.
Accepting this post conflict resolution.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments