-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An administrator should be able to delete any message #4921
Comments
Maybe have a new permission to override time block? There might be instances where an administrator would not want even owners to delete messages. |
I agree, a new permission that permit administrators/moderators/channel owner to delete in every case a message (bypassing global settings about time deletion). |
We have experienced the same problem on our rocketchat at https://community.storj.io and urgently need for this new permission type to be implemented in order to let mods and admins delete troll and spam posts after the time set for message deleting has run out. |
Yeah, this is really biting us right now. Almost bad enough to make this a non viable solution. I would go as far as to say that this is a bug as an administrator should be able to delete any message and requiring an admin (or sysadmin) to delete a message via the DB isn't super reasonable... |
@marceloschmidt I wouldn't mind building a PR for this to get it done. I'm not familiar with the codebase yet so some clarification and confirmation on how we should do this would be helpful if you have the time. From a quick look, looks like I'd need to do the following...
Anything that I'm missing? |
It seems to me you got it all covered. Thank you very much in advance for the PR. |
@marceloschmidt awesome, thanks for the confirmation. I'll aim to get something in here in the next week or so. |
@marceloschmidt here's a PR with the feature added... |
I think we can close this as my PR was merged and will be released soon. |
Rocket.Chat version: 0.45
An administrator (and a channel owner/moderator?) should not follow the rules set in the Deleting message settings (i.e. "Block Message Deleting After (n) Minutes").
The text was updated successfully, but these errors were encountered: