-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fragments support #15
Comments
I'm going to investigate in external fragments support and come with PR. |
Ok thanks! |
Waiting answer on the issue graphql/graphql-js#96 in GraphQL.js. |
@gyzerok ok cool. I refactored the project structure, so please check it before start implementing something: https://github.com/RisingStack/graffiti-mongoose/tree/master/src |
@hekike nice work! But I'm suggesting to use a little bit different file names. For example projection.js can be named getProjection.js. It's less confusing and this naming style is being used now in most repos as far as I know. Same with the schema.js - getSchema.js and etc. |
Also I think it would be nice to split core and utilitary modules. Core modules in our case seems to be those which implements a graffiti adapter interface and are directly connected to scheme generation while |
_P.S.:_ Or mb better names are |
@gyzerok I agree that we should do some improvement here, but I'm not 100% sure what would be the best for now. Let's wait a little bit with this, until everything will be clear in my mind. Btw it would be great to have a short Skype call about the future of |
@hekike Since I've started to play around GraphQL I thought about a tool to map existing MongoDB schema into GraphQL schema to avoid code duplication. How exited I was when found graffiti! So I'm very happy that I can help you somehow. It mb be hard to speak to each other cuz of my poor verbal english skills. But we can try. Find me as |
@gyzerok they fixed it: graphql/graphql-js#96 ;) |
@hekike Yes, saw it todays morning :) Gonna come back with a solution in a few days if you not hurry. |
The text was updated successfully, but these errors were encountered: